[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] #29984 Change file permission using octal numbers
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-05-16 18:43:13
[Download RAW message or body]

On Friday 16 May 2003 20:38, Tim Jansen wrote:
> On Friday 16 May 2003 18:14, Aaron J. Seigo wrote:
> > if anything, the dialog should be simplified. 
> 
> I have a proposal for a re-design. You can find a .ui and png here:
> 
> http://www.tjansen.de/other/file_properties.png
> http://www.tjansen.de/other/accesspermissionsexamples.ui
> 
> The files show four different replacements for the "Access Permissions" frame 
> of the original properties dialog. The content depends on the type of the 
> file (executable, directory) because the flags have different meanings for 
> different file types.
>  [...]

This looks very good, however it doesn't cater for one thing that this dialog
can currently do:
imagine you open the properties dialog after selecting a set of files (and/or dirs)
that don't all have the same permissions.
The current dialog will then use "tristate" checkboxes, for the permissions that
are not the same among the selected files/dirs.
This would mean a "no change" entry in your combos, I suppose.

But it also creates trouble for finding out in which mode you really are.
How does the current dialog do? Well, the "isDir" bool is only set if
all selected items are dirs. So if you select a mix of files and dirs you end
up with the labels for files.
The problem is that in your version there are 4 modes, so all sorts
of mixes between the 4 modes become possible, when selecting multiple
files.... Maybe the current form of the dialog should be kept for such
a case (multiple files selected)? A little bit confusing though.

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
[prev in list] [next in list] [prev in thread] [next in thread]