[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Fwd: Re: ksystraycmd
From:       Cédric Brégardis <cedric.bregardis () free ! fr>
Date:       2003-05-15 10:46:37
[Download RAW message or body]

Hi,

I made some modification of ksystraycmd and I sent the changed version to 
Richard Moore. Richard respond the message attached with this mail. That's 
why I send this message.

After I sent my changed version to Richard I made other modifications. So I 
now send you the last version with this mail. Here is the resume of the 
modifications :

1)
I add a new option (--ownicon) to always have the ksystraycmd icon in the 
systray instead of the icon of the target window. It can be useful if the 
window's icon is ugly and can't be changed with the classical kde option (eg 
: gkrellm which is a gtk application and don't know the --icon option). This 
option should be use with the standard "--icon" kde option to specify the 
icon.
Example:
ksystraycmd --icon /home/cedric/gkrellm.png --ownicon /usr/bin/gkrellm2

2)
I add the option --ontop which put the window always on top. (I wanted to have 
gkrellm2 always on top, but the integrated option didn't worked, and kstart 
used with ksystraycmd can't do that either)
Example:
ksystraycmd --ontop /usr/bin/gkrellm2

3)
Now the position of the window is memorized when the window is hidden and 
restored when the window is restored. I add XMoveWindow( qt_xdisplay(), win, 
left, top) just after XMapWindow( qt_xdisplay(), win ). Then the window is 
drawn and moved AFTER. So, the window flick, but it is really important i 
think to memorized the position.

4)
When the window is hidden and we ask to "quit" in the contextual menu, it 
doesn't work, because the "closeWindowRequest" must be send to a window, and 
there is no window (since it is hidden !). So I restaure the window with 
XMapWindow( qt_xdisplay(), win ) just before the "closeWindowRequest", and it 
works.

5)
The contextual menu now show "Restore" and "Hide" correctly (I hope). There 
were problems with --startonshow and --quitonhide.

6)
If the options --startonshow and --hidden are used together then when we 
activate the window by clicking on the systray or by choosing "restore" in 
the menu, the window is shown. The "--hidden" option prevented this, and i 
think it doesn't make sense (since with the --startonshow the window is 
already hidden in the beggining).

7)
The option --quitonhide now works with the contextual menu and not only with 
the mouse click.

8)
When ksystraycmd was launched without command and we asked to quit it didn't 
work. Now it should quit correctly.


Thank you,
Cédric Brégardis

PS : I don't speek english very well, so you could have to change my comments 
in the code.
["forwarded message" (message/rfc822)]

Return-Path: <rich@trinity.fluff.org>
Delivered-To: online.fr-cedric.bregardis@free.fr
Received: (qmail 28501 invoked from network); 14 May 2003 21:11:51 -0000
Received: from trinity.fluff.org (194.153.168.225)
  by mrelay4-2.free.fr with SMTP; 14 May 2003 21:11:51 -0000
Received: from rich by trinity.fluff.org  with local (Exim 3.35)
	id 19G3XI-0005Ii-00 for cedric.bregardis@free.fr
	; Wed, 14 May 2003 22:11:40 +0100
Date: Wed, 14 May 2003 22:11:40 +0100
To: C?dric Br?gardis <cedric.bregardis@free.fr>
Subject: Re: ksystraycmd
Message-ID: <20030514211140.GA18091@trinity.fluff.org>
References: <200305031628.24966.cedric.bregardis@free.fr>
Mime-Version: 1.0
Content-Type: text/plain;
  charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200305031628.24966.cedric.bregardis@free.fr>
User-Agent: Mutt/1.3.28i
From: Richard Moore <rich@trinity.fluff.org>
Status: R 
X-Status: N
X-KMail-EncryptionState: 
X-KMail-SignatureState: 

Hi Cedric,

This sounds like a good set of changes, but unfortunately I don't have
a working build of HEAD at the moment to test it. Do you think you could
forward this message to kde-core-devel so that someone with a working
system can give it a try?

Thanks

Rich.
ps. If it hasn't been handled when I get things working I'll take a look
myself.

On Sat, May 03, 2003 at 04:28:24PM +0200, C?dric Br?gardis wrote:
> Hi,
> I have corrected some bugs in ksystraycmd and add some few features :
> 
> 1)
> I add a new option (--ownicon) to always have the ksystraycmd icon in the 
> systray instead of the icon of the target window. It can be useful if the 
> window's icon is ugly and can't be changed with the classical kde option (eg 
> : gkrellm which is a gtk application and don't know the --icon option). This 
> option should be use with the standard "--icon" kde option to specify the 
> icon.
> Example:
> ksystraycmd --icon /home/cedric/gkrellm.png --ownicon /usr/bin/gkrellm2
> 
> 2)
> I add the option --ontop which put the window always on top. (I wanted to have 
> gkrellm2 always on top, but the integrated option didn't worked, and kstart 
> used with ksystraycmd can't do that either)
> Example:
> ksystraycmd --ontop /usr/bin/gkrellm2
> 
> 3)
> Now the position of the window is memorized when the window is hidden and 
> restored when the window is restored. I add XMoveWindow( qt_xdisplay(), win, 
> left, top) just after XMapWindow( qt_xdisplay(), win ). Then the window is 
> drawn and moved AFTER. So, the window flick, but it is really important i 
> think to memorized the position.
> 
> 4)
> When the window is hidden and we ask to "quit" in the contextual menu, it 
> doesn't work, because the "closeWindowRequest" must be send to a window, and 
> there is no window (since it is hidden !). So I restaure the window with 
> XMapWindow( qt_xdisplay(), win ) just before the "closeWindowRequest", and it 
> works.
> 
> 5)
> The contextual menu now show "Restore" and "Hide" correctly (I hope). There 
> were problems with --startonshow and --quitonhide.
> 
> 6)
> If the options --startonshow and --hidden are used together then when we 
> activate the window by clicking on the systray or by choosing "restore" in 
> the menu, the window is shown. The "--hidden" option prevented this, and i 
> think it doesn't make sense (since with the --startonshow the window is 
> already hidden in the beggining).
> 
> 7)
> The option --quitonhide now works with the contextual menu and not only with 
> the mouse click.
> 
> The modified version of ksystraycmd is  joined with this mail.
> Do you think that this work is interresting ?
> If you have any comment, mail me.
> 
> C?dric Br?gardis/




["ksystraycmd-modified2.tar.bz2" (application/x-tbz)]

[prev in list] [next in list] [prev in thread] [next in thread]