[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Make KShortcutMenu pass Enter, Return to QPopupMenu
From:       Maks Orlovich <mo002j () mail ! rochester ! edu>
Date:       2003-05-13 18:47:52
[Download RAW message or body]

On Tuesday 13 May 2003 02:36 pm, Aaron J. Seigo wrote:
> On Monday 12 May 2003 09:03, Maks Orlovich wrote:
> > On Wednesday 30 April 2003 11:53 pm, Maks Orlovich wrote:
> > > Hi...
> > >
> > > Currently, in case of an accel conflict, we popup a very nice menu
> > > letting the user make a choice between the two options.. The menu is
> > > also navigable with keyboard -- except, as #55139 points out, one can't
> > > actually activate an item like that, since KShortcutMenu intercepts
> > > enter (and most other keys) and calls close().
> > >
> > > The attached patch fixes that; please review.
> >
> > ping. If no one responds within a week, I think I'll have to commit -- I
> > don't think that we can let bugs go unfixed because no-one reviews a
> > nearly trivial patch that was posted 'just-in-case' :-(
>
> sorry, i've been stupidly busy =(  ok, now that my lame excuse is out of
> the way, on to the patch ;-)

Thanks, I know how that is...

> the patch looks good and indeed fixes a very annoying behaviour that i
> hadn't run in to until just now when verifying the bug your patch fixes...

OK, will commit then. What do you think of the space key issue?

Thanks again,
Maks
[prev in list] [next in list] [prev in thread] [next in thread]