[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fix 49564 - please review
From:       Waldo Bastian <bastian () kde ! org>
Date:       2003-03-12 10:19:20
[Download RAW message or body]

On Tuesday 11 March 2003 19:44, Ravikiran Rajagopal wrote:
> On Tuesday 11 March 2003 07:23 am, Waldo Bastian wrote:
> > I think it should mention the file that isn't writable. I would also like
> > to see an explicit config key to disable the dialog instead of abusing
> > the presence of the "[KDE Action Restrictions]" group for this.
> >
> > Other than that, I don't think it differentiates between the config file
> > being unwritable because of file permissions and the config file being
> > unwritable because the file starts with [$i] I think it's desirable not
> > to give a warning in the latter case.
>
> Objections noted, and hopefully fixed in the patch attached. Please review.

Almost. When I said "file starts with [$i]" I ment the file contents, not the 
file name.

Anyway, the case that you want to warn about happens when the 
        if (checkAccess(mLocalFileName, W_OK))
check in kconfigbackend.cpp line 216 fails

The "file starts with [$i]" case is handled in line 294 with
	if (bFileImmutable)
	   mConfigState = KConfigBase::ReadOnly;

Other than that, when you do
	if (config->readBoolEntry("CheckConfigFilesWritable",TRUE))
I don't think that any group is set. The command before does a hasGroup(), not 
a setGroup().

And why are parts between #ifdef Q_WS_X11 ? None of this is X specific.

Cheers,
Waldo
-- 
bastian@kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]