[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE 3.1 final tarballs
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-11-25 20:57:58
[Download RAW message or body]

On Monday 25 November 2002 18:10, Dirk Mueller wrote:
>
> I've created the final KDE 3.1 tarballs last night. I will not update
> them anymore unless there is a fix committed for a fatally bug,
> otherwise things have to wait till KDE 3.1.1.

The attached patch fixes a bug in KOrganizer which is fatal for 
birthday-type events (see bug report #51177). The bug makes KOrganizer 
unusable for people using all-day events. It would be really bad, if 
this fix wouldn't go into 3.1.

Unfortunately the bug was triggered by incrementing the version number 
to 3.1, so it wasn't detected earlier.

-- 
Cornelius Schumacher <schumacher@kde.org>
["birthday.patch" (text/x-diff)]

cvs -f log -N -r1.3 kdepim/libkcal/compat.cpp

RCS file: /home/kde/kdepim/libkcal/compat.cpp,v
Working file: kdepim/libkcal/compat.cpp
head: 1.3
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 4;	selected revisions: 1
description:
----------------------------
revision 1.3
date: 2002/11/25 20:32:28;  author: cschumac;  state: Exp;  lines: +1 -1
Correctly identify version number.

This is a critical bugfix. KOrganizer doesn't correctly read recurring
floating events, e.g. birthdays, without it. Unfortunately the bug was
triggered by incrementing the version number to 3.1.
=============================================================================
cvs -f diff -bp -u -r1.2 -r1.3 kdepim/libkcal/compat.cpp
Index: kdepim/libkcal/compat.cpp
===================================================================
RCS file: /home/kde/kdepim/libkcal/compat.cpp,v
retrieving revision 1.2
retrieving revision 1.3
diff -b -p -u -r1.2 -r1.3
--- kdepim/libkcal/compat.cpp	2002/10/27 08:15:55	1.2
+++ kdepim/libkcal/compat.cpp	2002/11/25 20:32:28	1.3
@@ -40,7 +40,7 @@ Compat *CompatFactory::createCompat( con
       int versionStop = productId.find( QRegExp( "[ /]" ), versionStart + 1 );
       if ( versionStop >= 0 ) {
         QString version = productId.mid( versionStart + 1,
-                                         versionStop - versionStart );
+                                         versionStop - versionStart - 1 );
         kdDebug(5800) << "Found KOrganizer version: " << version << endl;
         
         int versionNum = version.section( ".", 0, 0 ).toInt() * 10000 +


[prev in list] [next in list] [prev in thread] [next in thread]