From kde-core-devel Wed Oct 30 23:16:51 2002 From: Helge Deller Date: Wed, 30 Oct 2002 23:16:51 +0000 To: kde-core-devel Subject: Re: kcontrol/infocenter patch X-MARC-Message: https://marc.info/?l=kde-core-devel&m=103602002106137 On Thursday 31 October 2002 00:11, David Faure wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Wednesday 30 October 2002 23:58, Helge Deller wrote: > > On Wednesday 30 October 2002 23:51, David Faure wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > On Wednesday 30 October 2002 23:42, Helge Deller wrote: > > > > On Wednesday 30 October 2002 23:30, David Faure wrote: > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > > Hash: SHA1 > > > > > > > > > > On Wednesday 30 October 2002 23:20, Helge Deller wrote: > > > > > > Running "make install" in kdebase/kcontrol/kcontrol produces > > > > > > currently the following "Error" if KDE hasn't been installed yet: > > > > > > > > > > > > rm: cannot remove `/opt/kde/bin/kinfocenter': No such file or > > > > > > directory make[4]: [install-data-local] Error 1 (ignored) > > > > > > > > > > > > The attached patch fixes this for me. > > > > > > Ok to commit ? > > > > > > > > > > A simple -f after rm would do the job too ;) > > > > > (No need to create the symlink in the build dir) > > > > > > > > No, I think we had that once in the Makefile and it broke on > > > > some other arches than i386. > > > > > > AFAIK nobody complained about e.g. > > > kdebase/kcontrol/fileshare/Makefile.am since it uses "-rm -f". > > > > Ok, then I'll commit your "-f" solution, but I still think my second > > patch is a nicer solution :-) > > In all theory, if someone had a wrong symlink named kinfocenter (pointing > to the wrong thing), "make install" wouldn't fix it, with your 2nd patch. Sure, but that's really, _really_ hypotetical. Helge