From kde-core-devel Tue Oct 29 11:20:31 2002 From: David Faure Date: Tue, 29 Oct 2002 11:20:31 +0000 To: kde-core-devel Subject: Re: PATCH to make minicli use all KURIFilterPlugins X-MARC-Message: https://marc.info/?l=kde-core-devel&m=103589058523412 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 29 October 2002 02:28, Neil Stevens wrote: > On Monday October 28, 2002 01:48, David Faure wrote: > > Neil wrote: > > > I figure the easiest > > > stopgap solution is to use the existing filter iterator to produce a > > > QStringList of all installed filters. Then remove ikws, and we're > > > happy. > > > > Yes - and remove localdomainurifilter if !final. > > So the best would be to do that iteration once on start, and store the > > two QStringLists, ready to use for parseLine(). I'd happily approve a > > patch doing that ;) > > How about centralizing the pre-made list with the filters themselves, like > so? I don't see the need for this redundant storing. Why not implement plugins() (which should be called pluginNames() instead) in terms of "iterate over m_lstPlugins and collect names"? pluginNames() won't be called by all apps using the class, so the additional memory storage isn't worth it. OTOH I would still store the two lists as member variables in minicli, so that it doesn't have to remove() in each call to parseLine() - which is called for _every_ keypress! - -- David FAURE, david@mandrakesoft.com, faure@kde.org http://people.mandrakesoft.com/~david/ Contributing to: http://www.konqueror.org/, http://www.koffice.org/ Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9vm7/72KcVAmwbhARAvzOAJ9faV3rdP87zs0qPLdw2HpmrypmrwCbBYdP yoPDXhCV4pPtidU104gbxAg= =Ic36 -----END PGP SIGNATURE-----