[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: disabling kio_devices
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-10-29 11:09:37
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 29 October 2002 00:00, Stephan Kulow wrote:
> OK, please check the attached patch. It disallows the move of trash
> and delete for protocols that do not support deleting.

The _del change is ok, but the doFileCopy change isn't - it should do this test
only if _moving_, not if _copying_.
So I suggest to move the "filtering" under the "case QDropEvent::Move :" near
the end of doFileCopy().

Of course the problems with such a patch are:
* No feedback to the user (nothing happens)
* Actions should be disabled
* Similar checks should be done in job.cpp, to prevent other apps from
deleting things from that protocol.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9vmxx72KcVAmwbhARAnV5AKCJn7nxN+aeUK5IwXxx++QfBcbhRQCgiFlv
rVhYRgcZ5+yGiEM5AqI+7g4=
=EOWT
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]