From kde-core-devel  Mon Oct 28 22:33:30 2002
From: Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date: Mon, 28 Oct 2002 22:33:30 +0000
To: kde-core-devel
Subject: Re: [Patch:] KClipboard / klipper / kpaint bug fixes
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=103584376217290

-----BEGIN PGP SIGNED MESSAGE-----

On Monday 28 October 2002 20:52, Helge Deller wrote:

Hi,

> klipper will try to show your copied graphics as "text" which of course
> fails and thus it displays you some weird strings instead.

hmm, isn't that a bug in QClipboard? It should return QString::null if there 
is no text/* contents available.

> The follwing patches to
> - kdelibs/kdecore/kclipboard.[cpp|h],
> - kdebase/klipper/toplevel.[cpp|h] and
> - kdegraphics/kpaint/

This is a rather large patch. Can you please separate the cleanups from the 
bugfixes? The cleanup using QClipboard::Mode from Qt 3.1is ok. But please 
don't remove commented out debug-output, I'm quite sure, I will need it 
again. Also, please put condition and action into different lines, e.g. 

if ( foo )
  doSomething().

> - moves the clipboard syncronisation to kclipboard.cpp only. There should
> be no such code in klipper.cpp.

There is no synchronisation in klipper. But if you select an item in klipper's 
menu, you probably want it in both clipboard and selection, independent of 
the synchronization settings.

Regarding the removal of KClipboard::MimeSource, you can get a crash when you 
do something like clip->setText( clip->text( QClipboard::Selection ), 
QClipboard::Clipboard ).

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPb27PaWgYMJuwmZtAQGRCQf/Yz67u6Ym/ANISiZuGdf/bbv8BqjB9B3J
HjZxlRu4w/6yl91hKoolvS6CuhdZLacJf0VYYbw9nP6gPeSRRG0slUF6BVPUuI8Q
zfkH+1UpSgl/oIpN5l8nxiEh4bQ5Qksf+K/6UqlPyDwO01/0FoH1aGN+Vv4a5chS
Jgm416VzxX40BoJXyJrAbwqWpkgaGM5P2pvyowGhWPGQhhFv0XnSCgCruYh6gOlP
Tgotnohn3vWHVbn+XSU6c4HzbnSSFjcjqOvjDwy30bYOspa9aMlz7ocWKjZeEPk+
VJ+2/PsOHZLNms4V6I0dbwOnQgoMQdEO8UTARuxSXsh3y2ONRYzmuA==
=lO0e
-----END PGP SIGNATURE-----