[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Add dontAskAgainName parameter to queuedMessageBox()
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-10-07 22:56:26
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Sunday 06 October 2002 22:56, Ingo Klöcker wrote:
> Therefore please consider the attached patch which only adds the
> options parameter to KMessageBox::queuedMessageBox() (by overloading
> this member function). This makes it possible to display links also
> in queued message boxes.

Attached is an updated version of my patch which fixes the ambiguity in 
my previous patch. Is this patch bc? Can I commit?

Regards,
Ingo


["kmessagebox-add-options-param-to-queuedMessageBox.diff" (text/x-diff)]

Index: kmessagebox.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kmessagebox.cpp,v
retrieving revision 1.61
diff -u -3 -p -r1.61 kmessagebox.cpp
--- kmessagebox.cpp	2002/08/26 20:33:03	1.61
+++ kmessagebox.cpp	2002/10/07 22:35:41
@@ -788,6 +788,14 @@ int KMessageBox::messageBox( QWidget *pa
     return KMessageBox::Cancel;
 }
 
+void KMessageBox::queuedMessageBox( QWidget *parent, DialogType type, const QString \
&text, const QString &caption, int options ) +{
+   KMessageBox_queue = true;
+   (void) messageBox(parent, type, text, caption, KStdGuiItem::yes(),
+                     KStdGuiItem::no(), options);
+   KMessageBox_queue = false;
+}
+
 void KMessageBox::queuedMessageBox( QWidget *parent, DialogType type, const QString \
&text, const QString &caption )  {
    KMessageBox_queue = true;
Index: kmessagebox.h
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kmessagebox.h,v
retrieving revision 1.40
diff -u -3 -p -r1.40 kmessagebox.h
--- kmessagebox.h	2002/09/28 15:16:22	1.40
+++ kmessagebox.h	2002/10/07 22:35:42
@@ -610,6 +610,17 @@ public:
      */
     static void queuedMessageBox( QWidget *parent,
                     DialogType type, const QString &text,
+                    const QString &caption,
+                    int options );
+
+    /**
+     * @overload
+     *
+     * This is an overloaded member function, provided for convenience.
+     * It behaves essentially like the above function.
+     */
+    static void queuedMessageBox( QWidget *parent,
+                    DialogType type, const QString &text,
                     const QString &caption = QString::null );
 
 };


[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]