[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    default toolbar icon size settings
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2002-09-26 20:12:22
[Download RAW message or body]

This message is in MIME format.


I thought that my font settings weren't being respected (restored from        
KMainWindow::setAutoSaveSettings()).  As it turned out I had different       
settings for Main Toolbar Icon Size and Toolbar Icon Size.      
      
However, I made a couple of observations on the way to this amazing discovery:      
      
*) KToolbar doesn't check the right setting for toolbar icon sizes.  (patch     
attached -- though very possibly wrong) 
     
*) Why do we have different settings for "Main" toolbar icon sizes and other     
toolbar sizes? (globally -- in a specific application, where these are     
restored from the <app>rc file it makes perfect sense)  This seems really   
counterintuitive.   I doubt most users have any idea what the "main" toolbar  
is.  What's worse is that only the XML client checks for "main" toolbar 
settings, whereas when KToolbar is restoring the global default it always 
(trys) to use the "non-main" toolbar setting. 
 
I'll probably look through for other places that the icon setting name is 
inconcistant.  It looks like some of the KControl changes haven't completely 
propogated through the classes that read global settings. 
 
Cheers, 
 
-Scott  
["ktoolbar.diff" (text/x-diff)]

Index: ktoolbar.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/ktoolbar.cpp,v
retrieving revision 1.325
diff -u -3 -p -r1.325 ktoolbar.cpp
--- ktoolbar.cpp	2002/09/19 22:54:51	1.325
+++ ktoolbar.cpp	2002/09/26 19:33:04
@@ -1447,8 +1447,10 @@ void KToolBar::applyAppearanceSettings(K
         else
             icontext = "IconOnly";
 
-        // Use the default icon size for toolbar icons.
-        iconsize = gconfig->readNumEntry(attrSize, 0);
+        { // Use the default icon size for toolbar icons.
+	    KConfigGroupSaver toolbarIconGroup(gconfig, "ToolbarIcons");
+	    iconsize = gconfig->readNumEntry("Size", 0);
+	}
 
         if ( !forceGlobal && config->hasGroup(configGroup) )
         {


[prev in list] [next in list] [prev in thread] [next in thread]