[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDirWatcher and dnotify signal problem
From:       Lubos Lunak <l.lunak () sh ! cvut ! cz>
Date:       2002-09-09 15:02:30
[Download RAW message or body]

On Thursday 05 September 2002 20:38, Waldo Bastian wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thursday 05 September 2002 06:33 am, Lubos Lunak wrote:
> >  However, we should probably do something with the signal used. We're a
> > library and when just hardcoding SIGRTMIN this may clash with other piece
> > of code using SIGRTMIN. My original patch uses __libc_allocate_rtsig(),
> > which is not documented, and doesn't help much if somebody else hardcodes
> > SIGRTMIN anyway. I suggest we simply change SIGRTMIN to e.g.
> > (SIGRTMIN+15).
>
> That's fine with me.
>
> We should also add a runtime check for a working dnotify somewhere don't
> you think? If we make the use of DNOTIFY dependant on an env. variable then
> we can check in kcminit whether DNOTIFY works in combination with the linux
> kernel in use and set this env. variable accordingly.
>
> I guess we should add the check to kded even instead of kcminit, since kded
> is the first process to use kdirwatcher.

 I changed it to use SIGRTMIN+8 , and added a check for kernel version at 
least 2.4.18 (that's what I have here, I don't know what's the oldest one 
working).

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/



[prev in list] [next in list] [prev in thread] [next in thread]