[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDirWatcher and dnotify signal problem
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-09-02 18:38:56
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 02 September 2002 09:01 am, Lubos Lunak wrote:
>  Hello,
>
>  could somebody please review the attached patch? The theory is about like
> this: Whoever implemented the dnotify support in KDirWatch simply copied
> the example from kernel documentation. And the example uses SIGRTMIN for
> the signal. And LinuxThreads seem to use SIGRTMIN for its internal purposes
> in some configurations. 

Shouldn't it redefine SIGRTMIN in that case to account for that?

> So since the switch to Qt3 dnotify probably didn't
> work that great.
>
>  I've found some internal function in glibc for allocating the real-time
> signals and modified KDirWatch to use it. Could somebody review it?
>
>  BTW, now that the dnotify support finally seems to work, could it be
> enabled by default?

There was (is?) a kernel bug that broke dnotify whenever the process that uses 
dnotify forks and closes the dnotify file-descriptors in the child process. 
(Standard behaviour for KProcess) Has that been fixed already in recent 
kernels? Even then, we should probably detect the kernel version and only use 
it when we know it isn't broken.

Cheers,
Waldo
- -- 
bastian@kde.org  |   SuSE Labs KDE Developer  |  bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9c7BBN4pvrENfboIRAgzJAJ9FSnBIRr0b3l/pXPia7Fsy/ITTigCfRUp+
tTnCOoLSsQThLVY1YmXQQXI=
=CG6u
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]