[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Success: kde 3.1 cvs running on sgi IRIX!
From:       Thiago Macieira <thiagom () wanadoo ! fr>
Date:       2002-08-11 12:43:06
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dominique Devriese wrote:
>> kget/kmainwidget.cpp: cc-1020 CC: ERROR File = kmainwidget.cpp, Line =
>> 2150 The identifier "AF_IPX" is undefined.
>>
>>      			 ipx_sock = socket(AF_IPX, SOCK_DGRAM, 0);
>>
>> 			 don't know what that is; commented it out
>> (any ideas?)
>
>hm.. shouldn't that be PF_IPX  ?

AF_IPX and PF_IPX should have the same value. That is, I hope it's always that 
way, because many people, including myself, use one or the other 
indiscriminatedly. I really don't know when to use one or the other.

Anyways, it seems IRIX doesn't provide IPX support. Therefore, I think it's 
prudent to enclose the AF_IPX usage inside #ifdef, like what's done right 
below with AF_AX25. I've provided a patch; can you test it?

>
>> krfb/srvloc/kinetaddr.cpp: added #include <strings.h> for bzero
>
>hm.. shouldn't that be string.h ?

keep string.h only and change bzero(ptr, size) to memset(ptr, 0, size). It's 
more portable.

- -- 
  Thiago Macieira - UFOT Registry number: 1001
 thiagom@mail.com
   ICQ UIN: 1967141  PGP/GPG: 0x6EF45358
     Registered Linux user #65028
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9VlvaM/XwBW70U1gRAk3DAJoDo+pddQlYyiFWLVenm4VXEVUgJQCeKNMz
ivTV4tm3y4Uz7MQzDkQ00NQ=
=9k8E
-----END PGP SIGNATURE-----

["kget-kmainwidget.diff" (text/x-diff)]

Index: kmainwidget.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kget/kmainwidget.cpp,v
retrieving revision 1.40
diff -u -3 -p -r1.40 kmainwidget.cpp
--- kmainwidget.cpp	2002/07/16 15:47:19	1.40
+++ kmainwidget.cpp	2002/08/11 12:31:54
@@ -2147,7 +2147,13 @@ static int sockets_open()
 #endif
 
     inet_sock = socket(AF_INET, SOCK_DGRAM, 0);
+
+#ifdef AF_IPX
     ipx_sock = socket(AF_IPX, SOCK_DGRAM, 0);
+#else
+    ipx_sock = -1;
+#endif
+
 #ifdef AF_AX25
 
     ax25_sock = socket(AF_AX25, SOCK_DGRAM, 0);


[prev in list] [next in list] [prev in thread] [next in thread]