From kde-core-devel Sat Aug 10 06:54:49 2002 From: "Dawit A." Date: Sat, 10 Aug 2002 06:54:49 +0000 To: kde-core-devel Subject: Re: Short hostnames in URLs X-MARC-Message: https://marc.info/?l=kde-core-devel&m=102896282101382 On Friday 09 August 2002 09:59, Lubos Lunak wrote: > Dne p=E1 9. srpen 2002 07:52 Dawit A. napsal(a): > > On Thursday 08 August 2002 04:38, Lubos Lunak wrote: > > > Dne =E8t 8. srpen 2002 03:43 Dawit A. napsal(a): > > > > On Wednesday 07 August 2002 12:45, Lubos Lunak wrote: > I was just trying to say that I don't undestand why it should be moved > into its own plugin when there would be no difference besides it being in > its own plugin. Ahh, but there is. It is now simple to add an option to disable individual= =20 plugins. Each can also provide its own control module like the ebrowsing=20 (ikws) plugin does. This is why I wanted this feature to be separated out.= =20 I am almost certain that people with a much slower DNS (some dial up servic= e)=20 or a capped bandwidth limit will complain about such plugin since it has a= =20 tendency to generate a lot of traffic (I mean while attempting the look up)= =2E=20 Note I know this can also be done in the shorturi filter plugin using a sim= ple=20 flag, but I think we should resist this tendency.=20 > Unless you know a better place where to put the lookup, I've attached > (hopefully final and everybody sufficiently pleasing) another version. The > lookup is done in an extra URIFilter, and minicli uses this filter only f= or > the final filtering of the entered command (who cares the icon for local > hostnames will be wrong). This makes thing feature work fine in Konqy or > wherever else where it doesn't cause any serious problem, and not using it > in minicli while typing avoids any possible delays. I've also increased t= he > timeout to 1s. Great. I withdraw my objection then. This is a much better approach than= =20 sticking the code into the shorturi filter. Perhaps an option to enable or= =20 disable the plugin can be added into the ebrowing module as well ? [ ] Enable hostname lookup I can add this once you add the plugin if you do not object or you can add = it=20 yourself if you want. One last thing if I may. Perhaps a bit more=20 descriptive name is in order. For example "domainLookupFilter" which is wh= at=20 the plugin effectively does. Anyways, that does not really matter, just bei= ng=20 picky :) Regards, Dawit A.