[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    PATCH: dont display "transmission completed" before getting new mails
From:       Alexander Neundorf <alexander.neundorf () gmx ! net>
Date:       2002-08-07 23:56:07
[Download RAW message or body]

Hi,

I have 4 pop accounts in kmail, but all except the third one are configured 
with "exclude from check mail".
Now when pressing the toolbar button for "check mail" at first the message 
"Transmission completed. 0 new messages" appeared for some seconds on the 
status bar. After this correct status bar messages appeared.
The attached patch fixes this (I think).
Since in singleCheckMail() the jobs are started (i.e. this works async.), 
setting the status bar message at this point seems to me wrong.
Additionally it converts a 8-line-while-loop to a 3-line-for-loop.

Bye
Alex

["kmacctmgr.cpp.diff" (text/x-diff)]

Index: kmacctmgr.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmacctmgr.cpp,v
retrieving revision 1.76
diff -b -u -p -r1.76 kmacctmgr.cpp
--- kmacctmgr.cpp	2002/06/03 13:15:54	1.76
+++ kmacctmgr.cpp	2002/08/07 23:09:31
@@ -280,20 +280,9 @@ void KMAcctMgr::checkMail(bool _interact
 
   mTotalNewMailsArrived=0;
 
-  mAccountIt->toFirst();
-  while (TRUE)
-  {
+  for (mAccountIt->toFirst(); !mAccountIt->atLast(); ++(*mAccountIt))
     if (!mAccountIt->current()->checkExclude())
       singleCheckMail(mAccountIt->current(), _interactive);
-    if (mAccountIt->atLast()) break;
-    ++(*mAccountIt);
-  }
-
-  if (mTotalNewMailsArrived!=-1)
-    KMBroadcastStatus::instance()->setStatusMsg(
-	i18n("Transmission completed, %n new message.",
-	  "Transmission completed, %n new messages.", mTotalNewMailsArrived) );
-
 }
 
 


[prev in list] [next in list] [prev in thread] [next in thread]