[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Speculative patches for kdelibs/kdecore/kwinmodule
From:       David Boddie <david () sleepydog ! net>
Date:       2002-07-12 17:13:46
[Download RAW message or body]

These patches are speculative in that they modify a core component
in a way which will, no doubt, cause compatibility issues to arise.
I'm posting them now to elicit comment on their suitability for
inclusion in a future version of KDE.

They concern the addition of a signal for notifying clients of changes
to the current desktop viewport.

I'm away for two weeks and will out of necessity be unsubscribing to
this list, so I'd be grateful if comments could be copied to my e-mail
address as well as to this list.

My apologies to anyone who feels that I may be pursuing the issue
of viewport support rather aggresively. It's something I believe is
a useful addition to my desktop, and which I'd like to share with
others.

David

________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________
["kwinmodule.cpp.patch" (text/x-diff)]

Index: kwinmodule.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kwinmodule.cpp,v
retrieving revision 1.48
diff -u -3 -p -r1.48 kwinmodule.cpp
--- kwinmodule.cpp	23 Sep 2001 23:05:16 -0000	1.48
+++ kwinmodule.cpp	12 Jul 2002 16:19:04 -0000
@@ -48,6 +48,7 @@ public:
 				     ClientListStacking |
 				     NumberOfDesktops |
 				     DesktopGeometry |
+				     DesktopViewport |
 				     CurrentDesktop |
 				     DesktopNames |
 				     ActiveWindow |
@@ -132,6 +133,9 @@ bool KWinModulePrivate::x11Event( XEvent
     if ( ev->xany.window == qt_xrootwin() ) {
 	int m = NETRootInfo::event( ev );
 
+	if ( m & DesktopViewport )
+	    for ( module = modules.first(); module; module = modules.next() )
+		emit module->currentViewportChanged( currentDesktop() );
 	if ( m & CurrentDesktop )
 	    for ( module = modules.first(); module; module = modules.next() )
 		emit module->currentDesktopChanged( currentDesktop() );

["kwinmodule.h.patch" (text/x-diff)]

Index: kwinmodule.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kwinmodule.h,v
retrieving revision 1.15
diff -u -3 -p -r1.15 kwinmodule.h
--- kwinmodule.h	6 Dec 2001 13:03:57 -0000	1.15
+++ kwinmodule.h	12 Jul 2002 16:20:04 -0000
@@ -155,6 +155,11 @@ signals:
     /**
      * Switched to another virtual desktop.
      */
+    void currentViewportChanged( int );
+
+    /**
+     * Switched to another virtual desktop.
+     */
     void currentDesktopChanged( int );
 
     /**


[prev in list] [next in list] [prev in thread] [next in thread]