[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Viewport fault in netwm.cpp?
From:       David Boddie <david () sleepydog ! net>
Date:       2002-07-11 11:31:38
[Download RAW message or body]

On Thursday 11 Jul 2002 12:33 pm, Bradley T Hughes wrote:
> On Thursday 11 July 2002 12:54, David Boddie wrote:

> > I think I see what's happened. Presumably, the message constructed is
> > incorrect in that it mistakenly includes the desktop number at line 809:

[...]

> > 809:        e.xclient.data.l[0] = desktop - 1;
> > 810:        e.xclient.data.l[1] = viewport.x;
> > 811:        e.xclient.data.l[2] = viewport.y;
> > 812:        e.xclient.data.l[3] = 0l;
> > 813:        e.xclient.data.l[4] = 0l;

[...]

> > Is this the correct interpretation?
>
> Yes, this is correct.  The message only changes the viewport for the
> current desktop, so this event is incorrect and needs to be fixed.

I've attached another patch. 

David

________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________
["netwm.cpp.patch" (text/x-diff)]

Index: netwm.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/netwm.cpp,v
retrieving revision 1.65
diff -u -3 -p -r1.65 netwm.cpp
--- netwm.cpp	5 Jul 2002 19:52:26 -0000	1.65
+++ netwm.cpp	11 Jul 2002 11:27:57 -0000
@@ -806,11 +806,10 @@ void NETRootInfo::setDesktopViewport(int
 	e.xclient.display = p->display;
 	e.xclient.window = p->root;
 	e.xclient.format = 32;
-	e.xclient.data.l[0] = desktop - 1;
-	e.xclient.data.l[1] = viewport.x;
-	e.xclient.data.l[2] = viewport.y;
+	e.xclient.data.l[0] = viewport.x;
+	e.xclient.data.l[1] = viewport.y;
+	e.xclient.data.l[2] = 0l;
 	e.xclient.data.l[3] = 0l;
-	e.xclient.data.l[4] = 0l;
 
 	XSendEvent(p->display, p->root, False, netwm_sendevent_mask, &e);
     }


[prev in list] [next in list] [prev in thread] [next in thread]