[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Viewport fault in netwm.cpp?
From:       Bradley T Hughes <bhughes () trolltech ! com>
Date:       2002-07-11 11:41:08
[Download RAW message or body]

On Thursday 11 July 2002 13:31, David Boddie wrote:
> On Thursday 11 Jul 2002 12:33 pm, Bradley T Hughes wrote:
> > On Thursday 11 July 2002 12:54, David Boddie wrote:
> > > I think I see what's happened. Presumably, the message constructed
> > > is incorrect in that it mistakenly includes the desktop number at
> > > line 809:
>
> [...]
>
> > > 809:        e.xclient.data.l[0] = desktop - 1;
> > > 810:        e.xclient.data.l[1] = viewport.x;
> > > 811:        e.xclient.data.l[2] = viewport.y;
> > > 812:        e.xclient.data.l[3] = 0l;
> > > 813:        e.xclient.data.l[4] = 0l;
>
> [...]
>
> > > Is this the correct interpretation?
> >
> > Yes, this is correct.  The message only changes the viewport for the
> > current desktop, so this event is incorrect and needs to be fixed.
>
> I've attached another patch.

This one looks good.

> David
>
> ________________________________________________________________________
> This email has been scanned for all viruses by the MessageLabs SkyScan
> service. For more information on a proactive anti-virus service working
> around the clock, around the globe, visit http://www.messagelabs.com
> ________________________________________________________________________

-- 
Bradley T. Hughes - bhughes at trolltech.com
Trolltech AS - Waldemar Thranes gt. 98 N-0175 Oslo, Norway

[prev in list] [next in list] [prev in thread] [next in thread]