[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Viewport fault in netwm.cpp?
From:       David Boddie <david () sleepydog ! net>
Date:       2002-07-11 10:34:28
[Download RAW message or body]

I'm been looking at the viewport support in kdecore/netwm.cpp and found
that the wrong parameters appear to be passed to the virtual method,
changeDesktopViewport.

This patch changes some array references so that the viewport origin is
passed correctly.

On a related subject, can someone explain why there isn't there a signal
in the KWinModule class for changes to the viewport?

David

________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________
["netwm.cpp.patch" (text/x-diff)]

Index: netwm.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/netwm.cpp,v
retrieving revision 1.65
diff -u -3 -p -r1.65 netwm.cpp
--- netwm.cpp	5 Jul 2002 19:52:26 -0000	1.65
+++ netwm.cpp	11 Jul 2002 08:23:32 -0000
@@ -1151,8 +1151,8 @@ unsigned long NETRootInfo::event(XEvent 
 	    dirty = DesktopViewport;
 
 	    NETPoint pt;
-	    pt.x = event->xclient.data.l[0];
-	    pt.y = event->xclient.data.l[1];
+	    pt.x = event->xclient.data.l[1];
+	    pt.y = event->xclient.data.l[2];
 
 #ifdef   NETWMDEBUG
 	    fprintf(stderr, "NETRootInfo::event: changeDesktopViewport(%d, { %d, %d })\n",


[prev in list] [next in list] [prev in thread] [next in thread]