[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: proposal for redesign of toolbar menu feature in kdeui
From:       Nadeem Hasan <nhasan () nadmm ! com>
Date:       2002-07-02 14:08:24
[Download RAW message or body]

Quoting Simon Hausmann <hausmann@kde.org>:

> Hi,
<snip> 
> I attached three patches: One holding the actual diff for kdeui and
> two for kate/konqueror (both not using ui_standards.rc, illustrating
> the changes necessary) .

I like it :) Though I have a few comments:

1. The m_toolBars property in ToolBarHandler is used unintialized the first 
   time ToolBarHandler::setupActions()  is called.
2. In ToolBarHandler::setupActions(), I don't see a need to connect to the
   destroyed() signal of KToolBar, since ToolBarHandler::setupActions() is
   called anyway when aboutToShow() signal is emitted by QPopupMenu. Why create
   multiple code paths to achieve the same thing?

I apologze if I am completely out of line here.

In any case, after going through this patch, I think I now understand XMLGUI
a lot better. :)

Cheers,
--
Nadeem Hasan
nhasan@nadmm.com
http://www.nadmm.com/

______________________________________________________
This mail sent through http://webmail.nadmm.com/
[prev in list] [next in list] [prev in thread] [next in thread]