[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdesu patch
From:       Stephan Kulow <coolo () kde ! org>
Date:       2002-06-05 7:32:27
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Dienstag, 4. Juni 2002 12:39, Matthias Welwarsky wrote:
> On Tuesday 04 June 2002 11:37, Stephan Kulow wrote:
> > Hi!
> >
> > Some tools expect /sbin to be part of the root path as "su"
> > adds them (I'm not sure if it's set by some environment files
> > or if it's added by su itself - "su -" surely sets it through the
> > profile)
> >
> > Anyway, kdesu doesn't behave like that, so /sbin is missing.
> > Anyone objecting against the following patch?
> >
> > Greetings, Stephan
> >
> > --- stub.cpp    2002/03/04 00:59:16     1.17
> > +++ stub.cpp    2002/06/04 09:33:20
> > @@ -118,7 +118,13 @@
> >         } else if (line == "command") {
> >             writeLine(m_Command);
> >         } else if (line == "path") {
> > -           writeLine(getenv("PATH"));
> > +           QCString path = getenv("PATH");
> > +           if (m_User == "root")
>
> I always wondered if it's a good idea to hardcode "root" into some binary.
> "root" is just a convention, and I've frequently seen administrators
> renaming "root" to "ruth" or something ;) So checking for UID=0 is a better
> idea.
Feel free to rewrite kdesu, but for now "root" is the default user if you call 
"kdesu kcontrol"

Greetings, Stephan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8/b6LwFSBhlBjoJYRAlEmAJ9JoG3hcf1F53EjoAnh+gICAJqbdwCfcbrs
pJzfdCJh+/458txHK69sPMI=
=8PSW
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]