[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: got it! (Re: Kicker memory leaks)
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-05-09 20:48:24
[Download RAW message or body]

On Wednesday 08 May 2002 03:56 pm, Josef Weidendorfer wrote:
> Attached patch:
> - PanelBrowserMenu::slotClear reimplements KPanelMenu::slotClear
>   and correctly delete the submenus (Question: should submenu
>   deletion handling be done in KPanelMenu, as this deletion bug probably
>   exists for the K-Menu too ?!??).
> - KDirWatch events simply call slotClear; this is much better than
>   regenerating menus that aren't visible at all. The menus are always
>   regenerated if needed before they are shown (slotAboutToShow calls
>   initialize() !)
> - Menus should NOT be changed when shown. When shown, a change
>   is marked in a dirty flag. When the menu is shown the next time,
>   the menu is updated before (in initialize()).
> - Start KDirWatch as late as possible (in initialize()), and remove
>   it as early as possible (in slotClear())
>
> This leads to a much saner behaviour now. Note that opening a
> quickbrowser on /proc/self or on /tmp while compiling rendered
> kicker useless before this change.
>
> Please check and commit to BRANCH and HEAD again :-)

The patch has some weird interaction when a browser menu is torn off.

The torn off menu sort of disappears when something in the directory changes.

Cheers,
Waldo
-- 
bastian@kde.org  |   SuSE Labs KDE Developer  |  bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]