[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: got it! (Re: Kicker memory leaks)
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2002-05-08 16:27:29
[Download RAW message or body]

On Wednesday 08 May 2002 8:54, Josef Weidendorfer wrote:
> Hi all,
>
> I think I found the reason for one Kicker memory leak (thanks to
> Shane Wright).
> Patch attached.
> - It makes KDirWatch a direct member in PanelBrowserMenu. Somehow the
>   instances were not deleted when clearing the menu (in reinitilize),
>   leading to many KDirWatch instances. This should do it.

Strange, KDirWatch inherits QObject, so should be deleted when the parent is 
deleted. Still, I think this change makes things slightly cleaner.

> - The menu was reinitialized way to many times, as a dirty signal also
>   can mean a file change inside the watched directory. This is now
>   checked in reinitializeIfNeeded.

Yep, looks good.

> Can somebody check and apply to BRANCH and HEAD?
> (Perhaps even for KDE 3.0.1)

Please apply to both, if you have a CVS account.

-John
[prev in list] [next in list] [prev in thread] [next in thread]