[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] always keep one file-ioslave around
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-05-02 21:56:56
[Download RAW message or body]

On Thursday 02 May 2002 02:13 pm, aleXXX wrote:
> On Thursday 02 May 2002 21:41, Waldo Bastian wrote:
> > On Wednesday 01 May 2002 02:51 pm, aleXXX wrote:
> > > Hi,
> > >
> > > since the file ioslave is a very basic element, I think it would be a
> > > good idea to keep at least one of them always around, so that it hasn't
> > > got to be restarted. The attached patch for
> > > kdelibs/kio/kio/scheduler.cpp does this.
> >
> > No, I don't like this. It would increase the memory usage because every
> > application that has used a file-slave once will stick to it till the end
> > of times. If you want to do something like this you should do it in the
> > slave pool maintained by klauncher:
> >
> > When a slave isn't used any more by the application it is send back to
> > klauncher. When another application needs a slave, klauncher will check
> > its pool of slaves first before starting a new one.
> >
> > Cheers,
> > Waldo
>
> Right, I should look more exactly at the code before sending patches.

As long as you send patches first I don't mind :-) I guess it's a good example 
of "source code is speech", a patch can communicate the idea very clearly :-)

Cheers,
Waldo
-- 
bastian@kde.org  |   SuSE Labs KDE Developer  |  bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]