[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] KToggleToolbarAction, KWidgetAction
From: Simon Hausmann <hausmann () kde ! org>
Date: 2002-04-15 16:48:39
[Download RAW message or body]
On Mon, Apr 15, 2002 at 07:32:41AM +0200, Tobias Koenig wrote:
> On Mon, Apr 08, 2002 at 11:46:02PM -0700, John Firebaugh wrote:
> > On Monday 08 April 2002 2:10, Tobias Koenig wrote:
> > > On Mon, Apr 08, 2002 at 10:24:59PM +0200, Wilco Greven wrote:
> > > > Maybe we should add a KToggleStatusbarAction too for completeness. It
> > > > could be used in at least KMail and KGhostView.
> > >
> > > What is about KToggleMenuBarAction for konsole and maybe some other
> > > applications?
> >
> > Unfortunately KMenuBar and KStatusBar do not have a visibilityChanged() signal
> > like KToolBar, which is necessary for the action to update itself
> > automatically. I don't know why QWidget doesn't have a visibilityChanged()
> > signal... seems like an oversight to me.
>
> Since QMenuBar and QStatusBar do not have this signal the attached patch add
> it to KMenuBar and KStatusBar and provide the two new classes
> KToggleMenuBarAction and KToggleStatusBarAction. Maybe thet TTs could add
> the signals to QMenuBar and QStatusBar in the future so we can ommit this
> workaround. Is it ok to commit?
Frankly, what I dislike is that this patch duplicates a lot of code
(don't let David see the patch! :) . How about a KWidgetToggleAction
or something with a better name that abstracts the pattern of
listening to a certain signal and show/hide a given widget depending
on that state?
Simon
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic