From kde-core-devel Sun Apr 14 20:44:07 2002 From: Waldo Bastian Date: Sun, 14 Apr 2002 20:44:07 +0000 To: kde-core-devel Subject: Re: Bug#40835: toolbar icons work only as "icons only" X-MARC-Message: https://marc.info/?l=kde-core-devel&m=101881716213783 On Sunday 14 April 2002 11:14 am, Cristian Tibirna wrote: > (NOTE: this is not an answer, but an RFC directed to kde-core-devel) > > This bug report is not really related to kcmstyle, as the module itself > works very well. > > But try to go in katerc, kmailrc etc and remove the [*Toolbar*] > configuration sections. The first time the respective app starts after > this, it will obey the kcmstyle configuration. But it immediately saves > this configuration to its rc file, which makes that if user changes the > configuration in kcmstyle, the respective application won't obey anymor= e > (unless the config sections for the toolbars are removed again). > > Now, I believe there is a development guideline that says that default > configuration items aren't saved to the rc file. So, I ask: why don't t= he > toolbar ui classes obey this guideline? I mean, is there a special reas= on? Are we talking about the KConfig files or about XML files? I don't think there is a guideline that says that default configuration i= tems=20 aren't saved to config files. Although it certainly would make sense. In = KDE=20 2.x we always saved default values to config files afaik, in KDE 3.x we n= o=20 longer save default values iff the default value is defined in another co= nfig=20 file. But there are some limitations to this, e.g. if the default is defi= ned=20 in foorc then these defaults will not be taken into account when barrc is= =20 written. I'm not sure what the exact behaviour is when the defaults are=20 listed in $KDEHOME/share/config/kdeglobals and a $KDEHOME/share/config/fo= orc=20 file is written. It could very well be that such defaults are not taken i= nto=20 account either. It's the difference between "system defaults" (for all us= ers)=20 and "user defaults" (for all applications of a certain user). > Second, no matter what the answer is to the above question, I believe t= hat > the local toolbar settings (available through contextual menu of toolba= rs) > should include an item "use general settings" or "use default", which w= ill > effectively remove the config group from apps' rc file. Do you agree wi= th > me adding this? Yes. Note that "Icon Size" already has an "Default" entry. Cheers, Waldo --=20 bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com