From kde-core-devel  Tue Mar 19 14:39:25 2002
From: Stephan Binner <binner () kde ! org>
Date: Tue, 19 Mar 2002 14:39:25 +0000
To: kde-core-devel
Subject: Re: PATCH: cleanup in konsolepart, caption stuff
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=101655001807067

On Tuesday 19 March 2002 13:50, David Faure wrote:

> The attached patch fixes the signal/slot connect warnings when using
> konsolepart, finally fixing the small design flaw that TESession had
> to know about a KMainWindow. [..]  Ok to commit?

Look OK, but there is one "kdDebug()" and you don't need/have to connect

 +    void clearAllListenToKeyPress();
 +    void restoreAllListenToKeyPress();

in konsole_part. 1st is waste, 2nd afaik too as konsole_part doesn't DCOP.

Bye,
   Steve