[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KNewsTicker
From:       Lars Knoll <lars () trolltech ! com>
Date:       2002-03-11 16:15:06
[Download RAW message or body]


> Hi,
>
> I've attached three patches for KNewsTicker.
>
> newsiconmgr.diff fixes the NewsIconMgr class so that it properly deals with
> icons which are larger than 16x16 pixels and local images.
>
> newssourcedlgimpl.diff adjusts the dialog where you can add or modify a
> newssource so that it cares about the protocol of the icon's URL. This is
> necessary to make the NewsIconMgr retrieve the icon properly.
>
> These two patches (well, actually only the first one, but the second one is
> necessary to view the changes immediately) fix BR 32560.
>
> The third patch is in xmlnewsaccess.diff - it makes KNewsTicker parse even
> slightly invalid XML files (Those which start with whitespace instead of
> '<?xml'). The patch was apparently written by Lars and sent to me by
> Volker.
>
> Ok to commit?

The xmlaccess patch now calls setContent() twice. Apart from that the last 
patch looks good. Didn't look into the others.

Lars

[prev in list] [next in list] [prev in thread] [next in thread]