[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] knewsticker
From:       George Staikos <staikos () kde ! org>
Date:       2002-03-08 4:37:30
[Download RAW message or body]

KNewsticker didn't work on my machine.  After some probing I found out why.  
It is being loaded with appletproxy and it is giving it the configfile name 
"libknewstickerappletrc".  However the config panel writes 
knewstickerappletrc.  If I'm not mistaken, modules are not supposed to start 
with "lib" now right?  This changes that, and everything works fine.

In addition, why must all modules be loaded external now?  The option to load 
the modules internal seems to be gone (unless I'm just missing it somehow?).


-- 

George Staikos

["knewsticker.patch" (text/x-diff)]

Index: Makefile.am
===================================================================
RCS file: /home/kde/kdenetwork/knewsticker/Makefile.am,v
retrieving revision 1.39
diff -u -r1.39 Makefile.am
--- Makefile.am	2002/01/28 19:19:08	1.39
+++ Makefile.am	2002/03/08 04:31:13
@@ -1,16 +1,16 @@
 SUBDIRS = common kcmnewsticker kntsrcfilepropsdlg knewstickerstub
 INCLUDES = -I$(top_srcdir)/knewsticker/common $(all_includes)
 
-lib_LTLIBRARIES = libknewstickerapplet.la
+kde_module_LTLIBRARIES = knewstickerapplet.la
 
 noinst_HEADERS = newsscroller.h knewsticker.h
 
 METASOURCES = AUTO
 
-libknewstickerapplet_la_SOURCES = newsscroller.cpp \
+knewstickerapplet_la_SOURCES = newsscroller.cpp \
 	knewsticker.cpp knewsticker.skel
-libknewstickerapplet_la_LDFLAGS = $(all_libraries) $(KDE_PLUGIN)
-libknewstickerapplet_la_LIBADD = common/libknewstickercommon.la \
+knewstickerapplet_la_LDFLAGS = $(all_libraries) -module -no-undefined $(KDE_PLUGIN)
+knewstickerapplet_la_LIBADD = common/libknewstickercommon.la \
 	$(LIB_KIO) $(LIB_KDEUI)
 
 datadir = $(kde_datadir)/knewsticker
Index: knewsticker.desktop
===================================================================
RCS file: /home/kde/kdenetwork/knewsticker/knewsticker.desktop,v
retrieving revision 1.107
diff -u -r1.107 knewsticker.desktop
--- knewsticker.desktop	2002/03/07 09:31:16	1.107
+++ knewsticker.desktop	2002/03/08 04:31:13
@@ -44,5 +44,5 @@
 Icon=knewsticker
 Type=Application
 Terminal=0
-X-KDE-Library=libknewstickerapplet
+X-KDE-Library=knewstickerapplet
 X-KDE-UniqueApplet=true


[prev in list] [next in list] [prev in thread] [next in thread]