[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KDirLister: emitChanges, deleteItems
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-03-06 23:41:21
[Download RAW message or body]

On Thursday 07 March 2002 00:17, Michael Brade wrote:
> On Thursday 07 March 2002 00:05, /me wrote:
> > Attached is a patch to KDirLister which should fix all the bugs I'm aware
> > of right now. Only "missing features" are left :-}
> Haha, good joke =:-> 
> Here it comes...
:)

A remark about your questions in the comments for FilesChanged.
The old KDirLister handled it all - maybe having a look at the old code helps?
(cvs co -pr KDE_2_2_BRANCH kdelibs/kio/kdirlister.cpp > oldcode,
no need to check out the whole branch)

It was first making a list of directories to update, using KURL::directory()
on each url being passed (in the file items), and was then calling updateDirectory()
on those. That doesn't sound like the best solution though, the point is that
we know which files changed, so maybe a refreshItems() or whatever it's called
now would be better. This call isn't about files added or deleted, only about
files changed internally (e.g. change the icon of a .desktop file to test this).

See also the funny comment exchange we had in that method ;)
(But I think the whole problem will be void if we refresh the items instead
of listing the directories).

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
[prev in list] [next in list] [prev in thread] [next in thread]