[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KMessageBox
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-03-02 3:04:51
[Download RAW message or body]

On Saturday 02 March 2002 03:54, Waldo Bastian wrote:
> The following is a BIC patch for KMessageBox.
> 
> * It replaces "bool notify" with "int options".
> This allows us to add more options in a binary compatible way during the 
> development of KDE 3.x
> 
> * It adds a new option to allow links in the messagebox. This feature has been 
> added some time ago and was enabled by default. However, there is some 
> concern about the security implications of this since there might be cases 
> where the text in the messagebox comes from a remote server. To be on the 
> safe side, links in messageboxes are now disabled by default but can be 
> enabled by passing the KMessageBox::AllowLink option in cases where clickable 
> links are desired.

Thanks for taking care of this!

Just one thing that looks strange: the URL is still going to be shown as clickable,
even when AllowLink == false, no ? I thought the KActiveLabel (i.e. the QTextBrowser)
could be replaced with... hmm... some widget that shows richtext but not links,
is there something like that ? OK, not very important. Please apply.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today


[prev in list] [next in list] [prev in thread] [next in thread]