[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Problems with kxmlrpcd
From:       Thiago Macieira <thiagom () wanadoo ! fr>
Date:       2002-03-01 6:36:01
[Download RAW message or body]

I've been reviewing code, and I've found a showstopper problem with kxmlrpcd.

When compiling it, it complains about KSocket::ipv4_addr() not existing. 
That's because that's one of the functions I've just removed from KSocket 
(it's been marked as deprecated for almost a year and a half). That brings me 
to two questions:

1) should the deprecated functions be kept well into KDE 3.0? Currently, 
they're defined only within #ifdef's, but ksock.cpp compiles them. They are 
non-virtual functions, which would mean they can be safely removed later (can 
they?)

2) kxmlrpcd uses a QMap<unsigned long, int> to map the IP addresses (v4) to 
the number of connection attempts, so it can automatically ban attacks and be 
resonably safe. The code to use KSocketAddresses and comparison wouldn't be 
difficult, if it wasn't for one problem: QMap requires the ordering of the 
key element (that is, it uses < operator). The question is: is there another 
container that would provide the same association functionality to an int and 
not try to order the elements?

-- 
  Thiago Macieira - UFOT Registry number: 1001
 thiagom@mail.com
   ICQ UIN: 1967141  PGP: 0x8F2978D5 and 0xEA9037A5 (PGP 2.x)
     Registered Linux user #65028

[prev in list] [next in list] [prev in thread] [next in thread]