[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KTip
From:       Tobias Koenig <tokoe82 () yahoo ! de>
Date:       2002-02-21 22:26:28
[Download RAW message or body]


On Thu, Feb 21, 2002 at 12:48:06PM -0800, Waldo Bastian wrote:
> On Tuesday 19 February 2002 01:15 pm, Tobias Koenig wrote:
> > Hello,
He,

> > the two patches in attachment fix bug #28890 in ktip, so can I commit
> > them to CVS?
> 
> Can you either 
> a) remove the qWarnings
> or
> b) turn them into kdDebug calls
Ok, I added the kdDebug calls in the attached patches.

> > ATM we have the application ktip and the KTipDialog/KTipDatabase class
> > and both show tips to the user with nearly the same GUI. Are there
> > any objections against improving KTipDialog a bit (adding 'Previous'
> > button, adapt the backgroundcolor to ktip) and making ktip a wrapper for
> > KTipDialog?
> 
> Seems to me like the preferred approach. 
Could somebody please test the appended code on a host with current kde version
and give me an OK for commiting to cvs?

I moved the ctor of KTipDialog from protected to public so I guess it is BIC -
is the next possible time for a commit next friday?
After my changes ktip use the KTipDialog => if ktip should be run at startup
is no longer saved in kdewizardrc:General:TipOnStartup but in
ktiprc:TipOfDay:RunOnStartup. Is there an other program using this
kconfig entry?
ATM I have no complete current cvs checkout so I don't know if it works fine
in relationship to the other startup programs :(

Ciao,
Tobias
	P.S. sorry for the single patches I didn't know how to merge them
	     into one file
-- 
In a world without walls and fences who
needs Windows and Gates???

["ktip-patches.tar.bz2" (application/octet-stream)]

[prev in list] [next in list] [prev in thread] [next in thread]