[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Re: Adding parent and name arguments to KDirWatch' constructor
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-02-20 5:59:11
[Download RAW message or body]

On Monday 18 February 2002 02:29 pm, Josef Weidendorfer wrote:
> Hi,
>
> here is the long awaited patch for KDirWatch :-)
> The poll interval (only for STAT) now is determined inside of KDirWatch
> per file/dir watch.
> The constructor gets
> 	KDirWatch ( QObject* parent = 0, const char* name = 0);
> now; no need for any frequency.

Great.. small comment:
* I would read the pollinterval / nfspolinterval once in the KDirWatchPrivate 
constructor.
* Why is there an upper limit of 10 seconds? If a user wants to configure it 
so that it polls once evey 10 minutes then that should be possible too 
shouldn't it?

> The second patch is for cleaning up kded. I'm not aware of any
> other app using freq from old constructor. Thus, it's binary incompatible
> but kind of source compatible.
> Can somebody give it a try?

Seems to work fine.

> [ There is lots of debugging output, which can be commented out later]
>
> There has to be a config update, pulling (NFS)PollInterval from kded config
> into global config, group [DirWatch]... I never did such a thing.

It's simple... create a file kded.upd with the following contents:

# Migrating kdirwatch poll interval from kdedrc to kdeglobals
Id=kde3.0
File=kdedrc,kdeglobals
Group=General,DirWatch
Key=PollInterval
Key=NFSPollInterval

And install that file to $KDEDIR/share/apps/kconf_update:

update_DATA = kded.upd
updatedir = $(kde_datadir)/kconf_update

Cheers,
Waldo
-- 
Advanced technology only happens when people take a basic idea and add to it.
 -- Bob Bemer

[prev in list] [next in list] [prev in thread] [next in thread]