[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: control size of image generated by kimgio_eps_read
From:       Michael Matz <matz () kde ! org>
Date:       2002-02-12 1:37:45
[Download RAW message or body]

Hi,

On Tue, 12 Feb 2002, David Faure wrote:

> EPS is a scalable image format.

Hopefully I'm not starting a flamewar, but this:

+            if (params.count() >= 2 && x2 != 0.0 && y2 != 0.0)
+        if ( xScale != 1.0 || yScale != 1.0 )

is dubious.  comparing floats/doubles for (in)equaltity is nearly never
what one wants (instead "a {!=,==} b" do "abs(a-b) {>,<} eps").


Ciao,
Michael.

[prev in list] [next in list] [prev in thread] [next in thread]