Ok, my mistake. Then it is the applets page that needs the fixing then?
(Changing its QPushButtons to QToolButtons.)  Also, my other observation
about the way the tabs work on each page still ought to be corrected.

rob

-----Original Message-----
From: Matthias Ettrich [mailto:ettrich@trolltech.com] 
Sent: Friday, February 01, 2002 8:01 AM
To: Robert Shade; kde-core-devel@kde.org
Subject: Re: PATCH: kcontrol/kicker


On Friday 01 February 2002 06:17, Robert Shade wrote:
> Hi all,
>
> 	I'll try posting this here instead of kde-devel.  This is a
small 
> patch to change the buttons on the menus tab of the kicker (panel) 
> kcontrol module to QPushButtons instead of QToolButtons. (They look 
> different)
>

Those buttons are supposed to be tool buttons. Please see 
http://doc.trolltech.com/qpushbutton.html


"As a general rule, use a push button when the application or dialog
window 
performs an action when the user clicks on it (such as Apply, Cancel,
Close 
and Help) and when the widget is supposed to
have a wide, rectangular shape with a text label. Small, typically
square 
buttons that change the state of the window rather than performing an
action 
(such as the buttons in the top-right corner of the
QFileDialog) are not command buttons, but tool buttons. Qt provides a
special 
class (QToolButton) for these buttons. "


The macintosh calls those things bevel buttons and yes - they look
different 
from command buttons and so they should.

Matthias