[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KToggleAction: should setExclusiveGroup be a slot?
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2002-01-31 8:53:50
[Download RAW message or body]

On Wed, Jan 30, 2002 at 09:18:03PM +0100, Wilco Greven wrote:
> Hello,
> 
> I noticed a comment from David in kaction.h about setExclusiveGroup being a 
> slot. I can't think of a situation where one wants to change the group more 
> than once, so I also think it should be turned into a normal method. Should I 
> change it?

Agreed. You could also make the accessor (exclusiveGroup())
non-virtual, I think.


Simon
[prev in list] [next in list] [prev in thread] [next in thread]