[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ksmserver
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2002-01-30 18:41:01
[Download RAW message or body]

On Wednesday 30 January 2002 10:56, ossi@master.kde.org wrote:
> > Attached patch makes the ksmserver logout dialog
>
> i commited the Makefile.am part (changed according to dirk's notice)
> and the test.cpp part, as they are critical to some extent (the
> test.cpp breakage was to blame on me - i was just too lazy to update
> this useless test. :).
>
> regarding the gui part: i don't like the buttons to be so close to
> each other (this dialog has some symmetry i don't want to destroy :).
> the separator makes the whole thing look even more "vertically
> non-linear" (compressed towards the bottom). anybody knows how to reduce
> the space below the headline?

Hmm... well... if you have a better solution, feel free to commit that 
instead ;-)

I'll postpone the commit of this then. One request though: whatever you do, 
please switch to the KPushButtons as I did, because then the buttons are in 
line with the user's icon settings.

I agree that this particular dialog is a bit special because it has no window 
borders either, so making it look like a KDialogBase is nice but not really 
required.

Martijn
[prev in list] [next in list] [prev in thread] [next in thread]