From kde-core-devel Wed Jan 30 08:50:14 2002 From: Simon Hausmann Date: Wed, 30 Jan 2002 08:50:14 +0000 To: kde-core-devel Subject: Re: PATCH: make kaccelaction.h noinst_HEADER X-MARC-Message: https://marc.info/?l=kde-core-devel&m=101238070121016 On Tue, Jan 29, 2002 at 10:16:44PM -0500, Ellis Whitehead wrote: > I want to remove kaccelaction.h (which I first created a couple months ago) > from public installation for the sake of future flexibility. No public header > files include it and the only place that it's needed outside of kdecore is in > the kcontrol shortcut module: > > $ grep kaccelaction -r kdeaddons kdeartwork kdeedu kdegames kdegraphics kdemultimedia kdenetwork kdepim kdesdk kdeutils kdevelop kdevelopHEAD koffice > $ > $ grep kaccelaction -r kdebase > kdebase/kcontrol/keys/main.cpp:#include > kdebase/kcontrol/keys/shortcuts.h:#include > > So the commit will also add a copy of kaccelaction.h to kdebase/kcontrol/keys. > This isn't pretty, but it's a lot better than having to write hacks for the > next few years. I think that's a very good idea. Perhaps it might be worth adding a huge fat note in the header telling about this duplication and where to find the two copies. Simon