From kde-core-devel  Wed Jan 30 01:38:57 2002
From: Neil Stevens <neil () qualityassistant ! com>
Date: Wed, 30 Jan 2002 01:38:57 +0000
To: kde-core-devel
Subject: Re: PATCH - Disable All Sounds button in System Notifications
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=101235474105300
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------Boundary-00=_XW9QYVPGABN8VXBEDIGN"


--------------Boundary-00=_XW9QYVPGABN8VXBEDIGN
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

On Tuesday January 29, 2002 04:25, Waldo Bastian wrote:
> On Tuesday 29 January 2002 04:03 pm, Neil Stevens wrote:
> > > Not sure what would be better though.. maybe a checkbox?
> >
> > Wouldn't it be confusing, though, to have sounds checked on as well as
> > a box saying no sounds?  The UI would just be contradicting itself.
>
> Hm.. what about changing the text on the pushbutton then? So that we
> toggle between "disable all sounds" and "enable all sounds"?
>
> That would solve both problems nicely. We can check for
> !event->soundfile.isEmpty() to decide which sounds should be part of
> "all sounds".

I like that idea.  Here's the second patch attempt using that idea.

-- 
Neil Stevens
neil@qualityassistant.com

Don't think of a bug as a problem.  Think of it as a call to action.

--------------Boundary-00=_XW9QYVPGABN8VXBEDIGN
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="disablesoundspatch2"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="disablesoundspatch2"

SW5kZXg6IGtub3RpZnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGViYXNl
L2tjb250cm9sL2tub3RpZnkva25vdGlmeS5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTEK
ZGlmZiAtdSAtcjEuNTEga25vdGlmeS5jcHAKLS0tIGtub3RpZnkuY3BwCTIwMDIvMDEvMjUgMDk6
NDk6NTUJMS41MQorKysga25vdGlmeS5jcHAJMjAwMi8wMS8zMCAwMTozNjoyOApAQCAtMTEwLDYg
KzExMCw5IEBACiAgICAgY29ubmVjdCggdm9sdW1lU2xpZGVyLCBTSUdOQUwoIHZhbHVlQ2hhbmdl
ZCggaW50ICkgKSwgU0xPVCggY2hhbmdlZCgpICkgKTsKICAgICBsLT5zZXRCdWRkeSggdm9sdW1l
U2xpZGVyICk7CiAKKyAgICBzb3VuZEJ1dHRvbiA9IG5ldyBRUHVzaEJ1dHRvbiggYm94ICk7Cisg
ICAgLy8gdGhpcyBpcyBjb25maWd1cmVkIGluIHVwZGF0ZVZpZXcKKwogICAgIG1fZXZlbnRzID0g
bmV3IEV2ZW50cygpOwogICAgIHFBcHAtPnByb2Nlc3NFdmVudHMoKTsgLy8gbGV0J3Mgc2hvdyB1
cAogCkBAIC0xMzUsNiArMTM4LDcgQEAKICAgICBRTGlzdFZpZXdJdGVtICphcHBJdGVtID0gMEw7
CiAgICAgS05MaXN0Vmlld0l0ZW0gKmVJdGVtICA9IDBMOwogICAgIEtORXZlbnQgKmU7CisgICAg
Ym9vbCBzb3VuZHNEaXNhYmxlZCA9IHRydWU7CiAKICAgICBRUGl4bWFwIGljb24gPSBTbWFsbElj
b24oImlkZWEiKTsKIApAQCAtMTQ2LDYgKzE1MCw4IEBACiAKIAlLTkV2ZW50TGlzdEl0ZXJhdG9y
IGl0MiggKigqaXQpLT5ldmVudExpc3QoKSApOwogCXdoaWxlKCAoZSA9IGl0Mi5jdXJyZW50KCkp
ICkgeworCSAgICBpZihlLT5wcmVzZW50YXRpb24gJiBLTm90aWZ5Q2xpZW50OjpTb3VuZCkgc291
bmRzRGlzYWJsZWQgPSBmYWxzZTsKKwogCSAgICBlSXRlbSA9IG5ldyBLTkxpc3RWaWV3SXRlbSgg
YXBwSXRlbSwgZUl0ZW0sIGUgKTsKIAkgICAgZUl0ZW0tPnNldFBpeG1hcCggMCwgaWNvbiApOwog
CkBAIC0xNTYsNiArMTYyLDE4IEBACiAJKytpdDsKICAgICB9CiAgICAgdXBkYXRpbmcgPSBzYXZl
X3VwZGF0aW5nOworCisJc291bmRCdXR0b24tPmRpc2Nvbm5lY3QodGhpcyk7CisJaWYoc291bmRz
RGlzYWJsZWQpCisJeworCQlzb3VuZEJ1dHRvbi0+c2V0VGV4dCggaTE4bigiJkVuYWJsZSBBbGwg
U291bmRzIikgKTsKKwkJY29ubmVjdChzb3VuZEJ1dHRvbiwgU0lHTkFMKGNsaWNrZWQoKSksIHRo
aXMsIFNMT1QoZW5hYmxlQWxsU291bmRzKCkpKTsKKwl9CisJZWxzZQorCXsKKwkJc291bmRCdXR0
b24tPnNldFRleHQoIGkxOG4oIiZEaXNhYmxlIEFsbCBTb3VuZHMiKSApOworCQljb25uZWN0KHNv
dW5kQnV0dG9uLCBTSUdOQUwoY2xpY2tlZCgpKSwgdGhpcywgU0xPVChkaXNhYmxlQWxsU291bmRz
KCkpKTsKKwl9CiB9CiAKIApAQCAtMzU4LDcgKzM3NiwzMiBAQAogICAgIH0KIH0KIAordm9pZCBL
Tm90aWZ5V2lkZ2V0OjpkaXNhYmxlQWxsU291bmRzKCkKK3sKKwlmb3IoS05BcHBsaWNhdGlvbkxp
c3RJdGVyYXRvciBhcHAobV9ldmVudHMtPmFwcHMoKSk7IGFwcC5jdXJyZW50KCk7ICsrYXBwKQor
CXsKKwkJZm9yKEtORXZlbnRMaXN0SXRlcmF0b3IgZXZlbnQoKigqYXBwKS0+ZXZlbnRMaXN0KCkp
OyBldmVudC5jdXJyZW50KCk7ICsrZXZlbnQpCisJCXsKKwkJCSgqZXZlbnQpLT5wcmVzZW50YXRp
b24gJj0gfktOb3RpZnlDbGllbnQ6OlNvdW5kOworCQl9CisJfQorCXVwZGF0ZVZpZXcoKTsKKwlj
aGFuZ2VkKCk7Cit9CiAKK3ZvaWQgS05vdGlmeVdpZGdldDo6ZW5hYmxlQWxsU291bmRzKCkKK3sK
Kwlmb3IoS05BcHBsaWNhdGlvbkxpc3RJdGVyYXRvciBhcHAobV9ldmVudHMtPmFwcHMoKSk7IGFw
cC5jdXJyZW50KCk7ICsrYXBwKQorCXsKKwkJZm9yKEtORXZlbnRMaXN0SXRlcmF0b3IgZXZlbnQo
KigqYXBwKS0+ZXZlbnRMaXN0KCkpOyBldmVudC5jdXJyZW50KCk7ICsrZXZlbnQpCisJCXsKKwkJ
CWlmKCEoKmV2ZW50KS0+c291bmRmaWxlLmlzTnVsbCgpKQorCQkJCSgqZXZlbnQpLT5wcmVzZW50
YXRpb24gfD0gS05vdGlmeUNsaWVudDo6U291bmQ7CisJCX0KKwl9CisJdXBkYXRlVmlldygpOwor
CWNoYW5nZWQoKTsKK30KIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIAogLyoqCkluZGV4OiBrbm90aWZ5LmgKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZWJhc2Uva2NvbnRyb2wva25vdGlmeS9rbm90aWZ5
LmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTkKZGlmZiAtdSAtcjEuMTkga25vdGlmeS5oCi0t
LSBrbm90aWZ5LmgJMjAwMS8xMi8yOCAwMjoyOTowNwkxLjE5CisrKyBrbm90aWZ5LmgJMjAwMi8w
MS8zMCAwMTozNjoyOApAQCAtNTUsNiArNTUsOCBAQAogCiBwdWJsaWMgc2xvdHM6CiAgICAgdmly
dHVhbCB2b2lkIGxvYWQoKTsKKyAgICB2b2lkIGRpc2FibGVBbGxTb3VuZHMoKTsKKyAgICB2b2lk
IGVuYWJsZUFsbFNvdW5kcygpOwogCiBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgc2xvdFJlcXVl
c3RlckNsaWNrZWQoIEtVUkxSZXF1ZXN0ZXIgKiApOwpAQCAtNzEsNyArNzMsNyBAQAogICAgIFFD
aGVja0JveCAqY2JFeHRlcm5hbDsKICAgICBRTGlzdFZpZXcgKnZpZXc7CiAgICAgS1VSTFJlcXVl
c3RlciAqcmVxdWVzdGVyLCAqcmVxRXh0ZXJuYWw7Ci0gICAgUVB1c2hCdXR0b24gKnBsYXlCdXR0
b247CisgICAgUVB1c2hCdXR0b24gKnBsYXlCdXR0b24sICpzb3VuZEJ1dHRvbjsKICAgICBRU2xp
ZGVyICp2b2x1bWVTbGlkZXI7CiAgICAgRXZlbnRzICptX2V2ZW50czsKICAgICBLTkNoZWNrTGlz
dEl0ZW0gKmN1cnJlbnRJdGVtOwo=

--------------Boundary-00=_XW9QYVPGABN8VXBEDIGN--