[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ksmserver
From:       Dirk Mueller <mueller () kde ! org>
Date:       2002-01-29 22:32:06
[Download RAW message or body]

On Die, 29 Jan 2002, Martijn Klingens wrote:

> 
> As the patch itself is pretty much trivial I'd probably commit right away, 
> save for one thing: I needed to add '$(LIB_KDEUI)' to the Makefile.am, which 
> I don't consider trivial. Is there a reason for ksmserver not using kdeui, or 
> is it safe to commit this? 

I'm not sure why ksmserver is kdecore only (can't think of a reason), but if 
you have to add $(LIB_KDEUI), you should _replace $(LIB_KDECORE) with 
$(LIB_KDEUI) instead of appending it (because appending is anyway the wrong 
order). 



Dirk
[prev in list] [next in list] [prev in thread] [next in thread]