[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: kdelibs/kio/kfile
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2002-01-29 0:45:28
[Download RAW message or body]

On Montag, 28. Januar 2002 18:14, Ellis Whitehead wrote:

Hiya,

> Here's a patch to kdelibs/kio/kfile to get KDirOperator popup menu to have
> the view's options in the view submenu again.  It also avoids old creating
> of an additional KActionCollection object and swapping action pointers
> between collections.
>
> Previously, KDirOperator relied on inserted() and removed() signals from
> KFilePreview's KActionCollection object.  This approach required using
> actionCollection() as a pointer container, however, and the problems with
> this have already been discussed.  By making KFileView::actionCollection()
> virtual, KFilePreview can pass on the actionCollection of the view it
> holds.

Great, looks good to me. Please commit (I hope it works, no time for testing 
right now). You can also remove the commented out KActionCollection 
insertions/removings then, I guess.

Thanks
Carsten Pfeiffer
[prev in list] [next in list] [prev in thread] [next in thread]