[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KParts::ReadWritePart
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-01-25 14:45:33
[Download RAW message or body]

On Friday 25 January 2002 15:29, Matthias Kretz wrote:
> On Thursday 24 January 2002 18:10, David Faure wrote:
> > I thought about doing it that way, but it's incomplete. In case of errors
> > you want to set it to false too.
> > (in the isMalformed case of saveAs, and in case of an error in
> > slotUploadFinished - ah you took care of that one already).
> > Ok, then just one m_bClosing=false to add in saveAs, and this should be 
ok.
> 
> patch attached, may I apply?

Looks good, please apply.

> > Here again, anyone reimplementing saveAs etc. is in trouble... although
> > there aren't many reasons to reimplement those.
> 
> Yes, then he has to reimplement closeURL, save, saveFile, saveAs, saveToURL
> and create his own m_bClosing flag.
Indeed.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david, http://www.konqueror.org
KDE 3.0: Konquering the Desktops

[prev in list] [next in list] [prev in thread] [next in thread]