[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [rfc] KScroller
From:       Per Winkvist <nd96pwt () adeptus ! student ! hig ! se>
Date:       2002-01-10 20:40:15
[Download RAW message or body]

Hi,

> > The following is a widget to handle middle mouse button scrolling for
> > different widgets. I have tested it on listbox, textedit, table.
> >
> > Comments are more than greatly appreciated.
>
> Looks good to me. Two comments: 
> - default arguments for parameters have to be in the header file, not in
> the cpp-file.

Okay, I forgot this. I remember SunWS compiler didn't like this.

> - an KConfig check might be necessary so that a user can disable this

Yes, I have a patch to add it to khtml + KConfig option. How this looks
like can be found @

http://www.student.hig.se/~nd96pwt/free_scroller.gif (anim gif)

> Not sure if it can be added for KDE 3.0 [generally I'd say no, but
> mosfets effects have been added in the freeze as well, so... ]
>
> Cheers
> Carsten Pfeiffer

Thanks for the feedback, it could be added later if people find it useful.

Per

[prev in list] [next in list] [prev in thread] [next in thread]