[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Masking for radio buttons in high-color style
From:       Fredrik =?iso-8859-1?q?H=F6glund?= <fredrik () kde ! org>
Date:       2001-12-02 16:57:27
[Download RAW message or body]

On Sunday 02 December 2001 08:39, Karol Szwed wrote:
> On Sunday 02 December 2001 17:29, Waldo Bastian wrote:
> > Hi Fredrik,
> >
> > The masking for radiobuttons in the high-color style is broken for me.
> > This causes the radiobuttons to disappear from forms in khtml.
> >
> > The following patch fixes it for me.
>
> It works fine here too. Thanks!
> When I was porting highcolor originally, the Qt3 beta had troubles with
> masking, and Fredrik seemed to find that the current Qt also had some
> masking problems for which the inverted bitmap was a workaround -
> unfortunately not a successful one it seems. :-)
>
> I've committed your patch so khtml forms work properly once again.
>
> Regards,
> Karol

Yes, I noticed this problem the day after I committed that workaround.
It only happens when a webpage sets a different background color for
the radio buttons. Sorry about breaking things.

The problem with this patch is that it implements the original solution from
KDE 2.x - the one that we couldn't get to work in KDE 3 because it seems to
break automasking for radio buttons in all applications.

As you probably notice, with this patch applied the radio buttons aren't
masked, resulting in gray rectangles being drawn behind the radio buttons
in khtml.

I've committed a slightly different solution to the problem that I've been
working on this weekend that should work everywhere. There are however some
bugs in khtml that effect masking of form elements. I'm currently working on a
testcase for this. Those bugs are in khtml and not in the style.

I'd also like to ask the translators to test if this commit fixes the
problems people have been having with BiDi languages and popup menus.

Regards,
Fredrik

[prev in list] [next in list] [prev in thread] [next in thread]