[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdeui/kaction.h
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-11-16 9:28:18
[Download RAW message or body]

On Friday 16 November 2001 07:02, Waldo Bastian wrote:
> Hi,
> 
> In kaction.h the "setStatusText" method is marked as "to be removed in KDE 
> 3.0", however a quick grep showed that it is still quite much in use.
> 
> setStatusText is supposed to be replaced with setToolTip

Yes, since setToolTip is what does things internally, whereas setStatusText does nothing.

> There are also:
>   void actionStatusText( const QString &text );
>   void clearStatusText();
> 
> which are rather strange names after setStatusText is removed.

  emit actionStatusText( d->m_currentHighlightAction->toolTip() );
well isn't that a strange combination of names too ? ;) 

Here's the rationale, IIRC:
we had both at some point. But in fact they're about the same thing:
setting the "additional text" for this action, which will turn into a tooltip
if it's a toolbar button, and into statusbar text if it's a menu item _and_
the application connects to the actionHighlighted or actionStatusText
signals from KActionCollection.
So the hard part is to find how to name the KAction setBlah() method,
since it does both. I almost named it setDetails() or setDescription() or
whatever, but I chose to keep setTooltip since it already existed.
Of course this leads to a strange mixture when it finally ends up in
the actionStatusText signal...
Tell me which way you prefer, but I really think this should get cleaned up.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE 3.0: Konquering the Desktops

[prev in list] [next in list] [prev in thread] [next in thread]