[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [RFC/PATCH] mailing installation problem messages?
From:       Michael Matz <matz () kde ! org>
Date:       2001-11-04 19:09:25
[Download RAW message or body]

Hi,

On Sun, 4 Nov 2001, Oswald Buddenhagen wrote:

> what do you think about this patch?

Reasons for badness of that in increasing order:
You removed the '-' of the install-commands, making them stop at the error
which removes the purpose of that patch, as you formulated it in the
mailerror script.  You send mail only in a selected case of possibly fatal
install errors, which is incosistent.  You send mail without testing if
that's possible and without the possibility to switch that off.  You send
mail by default.  You send mail at all, which is not The Way It Should Be.

If anything modify your local mkpamserv script to send mail for you, and
don't commit it.


Ciao,
Michael.

[prev in list] [next in list] [prev in thread] [next in thread]