[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    kglobalaccel bug with forthcoming Qt 2.3.2
From:       Lars Knoll <knoll () kde ! org>
Date:       2001-10-31 14:16:13
[Download RAW message or body]

Hi,

we just found a bigger bug in kglobalaccel.cpp, that will make some problems 
with the upcoming qt-2.3.2 version.

Basically, the problem is, that an application having global accelerators 
will always ungrab the keyboard after the first key press. This breaks 
keyboard navigation in popup menues in 2.3.2.

The fix is to only ungrab the keyboard in case we really press a global 
accelerator.

Packagers: If you upgrade to qt-2.3.2, please also use the latest version of 
kglobalaccel.cpp in kdecore.

The same problem should also exist in KDE-3, but I can't test this currently. 
Could someone please check and apply the patch there aswell (I checked it 
into the 2.2 branch already).

Thanks,
Lars


Index: kglobalaccel.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kglobalaccel.cpp,v
retrieving revision 1.64
diff -u -r1.64 kglobalaccel.cpp
--- kglobalaccel.cpp    2001/07/07 04:06:13     1.64
+++ kglobalaccel.cpp    2001/10/31 14:06:31
@@ -538,6 +538,9 @@
        }
     }
 
+    if ( sConfigKey.isNull() )
+       return false;
+
     if ( !QWidget::keyboardGrabber() ) {
        kdDebug(125) << "received action " << sConfigKey << endl;
        if ( !d->rawModeList || !d->rawModeList->contains( sConfigKey ) ) {

[prev in list] [next in list] [prev in thread] [next in thread]