[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] i18n arts (Directory and File Name)
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-10-03 17:23:14
[Download RAW message or body]

On Monday 01 October 2001 22:47, Malte Starostik wrote:
>Am Monday 01 October 2001 15:25 schrieb Toshitaka Fujioka:
>> Hello,
>>
>> This patch can open directory or file name including non-latin1
character
>> with Kaboodle, noatun and etc.. .
>>
>> I attached patch for CVS HEAD. Sorry, I have only CVS HEAD.
>> Please commit to HEAD and KDE_2_2_BRANCH if this patch has not a
problem.
>
>+ instream.openURL((const char*)url.prettyURL().local8Bit());
>Please don't use prettyURL(), but url(), as prettyURL() strips the
password
>if any, and if the user specifies a URL with password he'll most likely

>want it to stay in there :)
>
>+ return new KPlayObject(m_server.createPlayObjectForURL(string((const
>char*)url.path().local8Bit()), string(mimetype.latin1()), createBUS),
>false); IMHO this should rather be
string(QFile::encodeName(url.path())).

Oh, I see. Thank you for your advice.
I remade a patch. Is this Ok ?

>Apart from that, looks good to me.

Thank you.

["kdelibs-arts-i18n-20011004.diff" (text/plain)]

? kdelibs-arts-i18n-20011004.diff
Index: kplayobjectfactory.cc
===================================================================
RCS file: /home/kde/kdelibs/arts/kde/kplayobjectfactory.cc,v
retrieving revision 1.14
diff -u -3 -d -p -r1.14 kplayobjectfactory.cc
--- kplayobjectfactory.cc	2001/09/02 11:56:22	1.14
+++ kplayobjectfactory.cc	2001/10/03 14:58:26
@@ -24,6 +24,8 @@
 #include "artskde.h"
 #include "kplayobjectfactory.h"
 
+#include <qfile.h>
+
 using namespace std;
 
 KPlayObjectFactory::KPlayObjectFactory(Arts::SoundServerV2 server)
@@ -55,7 +57,7 @@ KPlayObject *KPlayObjectFactory::createP
 			return new KPlayObject(m_server.createPlayObjectForStream(instream, \
string("audio/x-mp3"), createBUS), true);  }
 		else
-			return new KPlayObject(m_server.createPlayObjectForURL(string(url.path().latin1()), \
string(mimetype.latin1()), createBUS), false); +			return new \
KPlayObject(m_server.createPlayObjectForURL(string(QFile::encodeName(url.path())), \
string(mimetype.latin1()), createBUS), false);  }
 	else
 		return new KPlayObject();



[prev in list] [next in list] [prev in thread] [next in thread]